Skip to content

[Bookings][Part 6] Booking cancellation dialogue and currency formatting #16209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 7, 2025
Merged

[Bookings][Part 6] Booking cancellation dialogue and currency formatting #16209

merged 5 commits into from
Oct 7, 2025

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Oct 3, 2025 •
edited
Loading

Part of: WOOMOB-1236

Description

  • Adds booking cancellation dialogue alert. No data binding / action yet.
  • Adds currency formatting for "Appointment details" and "Price" sections. Uses new currency field from Booking.
  • Renames "Mark as refunded" -> "Issue refund". And temporarily hardcodes the "Issue refund" action to be shown.

Testing steps

  • Use a CIAB site with existing bookings.
  • Go to bookings tab.
  • Select a booking.
  • In "Appointment details" section tap on "Cancel booking" button.
  • Make sure the alert dialogue looks ok, title and formatted message match show correct content.
  • Make sure prices in "Appointment details" and in "Price" sections have the correct currency symbol.
  • To double-check price symbols - manually hardcode some other currency code string in Booking.swift on line 101. Navigate to a booking details after and make sure the corresponding currency symbol is presented.
  • Make sure that the "Issue refund" CTA is presented in "Payments" section.

Testing information

Tested on iOS 26 iPhone 17 and iPad simulators.

Screenshots

Снимок экрана 2025-10-03 в 14 48 54
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.5 milestone Oct 3, 2025
@RafaelKayumov RafaelKayumov added the type: task An internally driven task. label Oct 3, 2025
@RafaelKayumov RafaelKayumov modified the milestones: 23.5, 23.4 Oct 3, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 3, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16209-4823ccd
Version23.4
Bundle IDcom.automattic.alpha.woocommerce
Commit4823ccd
Installation URL215snmu5952m0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@staskus staskus modified the milestones: 23.4, 23.5 Oct 3, 2025
@itsmeichigo itsmeichigo self-assigned this Oct 6, 2025
itsmeichigo
itsmeichigo approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@itsmeichigo
Copy link
Contributor

itsmeichigo commented Oct 7, 2025

Screenshot 2025-10-06 at 18 42 26

Nit: the text color in the yellow badge may need to be changed in dark mode for better readability.

@RafaelKayumov
Copy link
Contributor Author

RafaelKayumov commented Oct 7, 2025

Screenshot 2025-10-06 at 18 42 26 Nit: the text color in the yellow badge may need to be changed in dark mode for better readability.

Thx for noticing. I'll work on it under a separate issue: WOOMOB-1434

@RafaelKayumov
Merge branch 'trunk' into WOOMOB-1236-booking-details-part-6
4823ccd 
# Conflicts:
#	WooCommerce/WooCommerce.xcodeproj/project.pbxproj
@RafaelKayumov RafaelKayumov merged commit ddfaa9f into trunk Oct 7, 2025
13 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1236-booking-details-part-6 branch October 7, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsmeichigo itsmeichigo itsmeichigo approved these changes

Assignees

@itsmeichigo itsmeichigo

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.5

Development

Successfully merging this pull request may close these issues.

5 participants

@RafaelKayumov @wpmobilebot @itsmeichigo @staskus